Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auto_ip back to os_server provisioning #667

Merged
merged 1 commit into from
Aug 31, 2018
Merged

add auto_ip back to os_server provisioning #667

merged 1 commit into from
Aug 31, 2018
+3 −0

Conversation

14rcole
Copy link
Contributor

@14rcole 14rcole commented Aug 29, 2018 •
edited by herlo
Loading

sk and I found this while working on on #596

Fixes #596

@14rcole
add auto_ip back to os_server provisioning
7930dd5 
Signed-off-by: Ryan Cole <rycole@redhat.com>
@adl-bot
Copy link

adl-bot commented Aug 29, 2018

Can one of the admins verify this patch?

@adl-bot
Copy link

adl-bot commented Aug 29, 2018

ci-linchpin-messageBus-trigger build #218: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/218/

@samvarankashyap samvarankashyap self-requested a review August 29, 2018 19:09
samvarankashyap
samvarankashyap approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@samvarankashyap samvarankashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samvarankashyap
Copy link
Contributor

[test]

@adl-bot
Copy link

adl-bot commented Aug 29, 2018

ci-linchpin-messageBus-trigger build #219: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/219/

@14rcole
Copy link
Contributor Author

14rcole commented Aug 29, 2018

[test]

@adl-bot
Copy link

adl-bot commented Aug 29, 2018

ci-linchpin-messageBus-trigger build #222: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/222/

@herlo
Copy link
Contributor

herlo commented Aug 29, 2018

[test]

@adl-bot
Copy link

adl-bot commented Aug 29, 2018

ci-linchpin-messageBus-trigger build #223: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/223/

@samvarankashyap
Copy link
Contributor

[test]

@adl-bot
Copy link

adl-bot commented Aug 30, 2018

ci-linchpin-messageBus-trigger build #229: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/229/

@herlo
Copy link
Contributor

herlo commented Aug 30, 2018

[test]

@adl-bot
Copy link

adl-bot commented Aug 30, 2018

ci-linchpin-messageBus-trigger build #237: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/237/

@adl-bot
Copy link

adl-bot commented Aug 30, 2018

ci-linchpin-messageBus-trigger build #239: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/239/

@14rcole
Copy link
Contributor Author

14rcole commented Aug 31, 2018

@herlo good to merge?

@herlo
Copy link
Contributor

herlo commented Aug 31, 2018

@p3ck this seems to be a regression, can we include it in v1.6.1?

@herlo
Copy link
Contributor

herlo commented Aug 31, 2018

[merge] per conversation with @p3ck in IRC

@adl-bot adl-bot merged commit f7e5474 into CentOS-PaaS-SIG:develop Aug 31, 2018
@herlo herlo added this to the v1.6.1 milestone Aug 31, 2018
@adl-bot adl-bot mentioned this pull request Dec 10, 2018
Merged
@adl-bot adl-bot mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvarankashyap samvarankashyap samvarankashyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@14rcole @adl-bot @samvarankashyap @herlo