Added mocking data and mocking integration tests for azure #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
14rcole
reviewed
Mar 3, 2020
|
Junqi, what do you mean by differentiating present and absent data? Isn't the data generated by provisioning (present) the data used by teardown (absent)? |
|
@14rcole No, they are using different data, I added code for SK's collector to collect both present data and absent data. Do you think it's necessary? I personally think it's not that necessary to test the Teardown part because if the provision part works fine then the teardown should also work fine. But @samvarankashyap said for consistency, we need to provide both data, I agree. What's your opinion? |
|
[test] |
2 similar comments
|
[test] |
|
[test] |
|
Do you mean that the provider returns different data on teardown? |
|
@14rcole yes |
|
[test] |
1 similar comment
|
[test] |
JunqiZhang0
force-pushed
the
mockazure
branch
2 times, most recently
from
215bdef to
41cf905
Compare
|
[test] |
|
[TEST] |
|
[test] |
…oth present and abesnt
…because it's not collected yet
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mocking data and mocking integration tests for azure. It also differentiated the present data and absent data. All other providers should do the same. fix #1531