Make openstack role OASIS-compatible #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Cole <rycole@redhat.com>
14rcole
requested review from
samvarankashyap,
abraverm and
p3ck
and removed request for
samvarankashyap and
abraverm
linchpin/provision/roles/openstack/tasks/provision_os_keypair.yml
Outdated
Show resolved
Hide resolved
p3ck
reviewed
Feb 3, 2020
config/Dockerfiles/Jenkinsfile
Outdated
| @@ -4,8 +4,7 @@ env.ghprbGhRepository = env.ghprbGhRepository ?: 'CentOS-PaaS-SIG/linchpin' | |||
| env.ghprbActualCommit = env.ghprbActualCommit ?: 'develop' | |||
| env.ghprbSourceBranch = env.ghprbSourceBranch ?: 'develop' | |||
| env.ghprbTargetBranch = env.ghprbTargetBranch ?: 'develop' | |||
| env.ghprbPullAuthorLogin = env.ghprbPullAuthorLogin ?: '' | |||
| env.ghprbPullId = env.ghprbPullId ?: '' | |||
| env.ghprbPullAuthorLogin = env.ghprbPullAuthorLogin ?: '' env.ghprbPullId = env.ghprbPullId ?: '' | |||
There was a problem hiding this comment.
this shouldn't all be on one line should it?
There was a problem hiding this comment.
That shouldn't have been changed at all, thanks for the catch
14rcole
force-pushed
the
openstack-galaxy
branch
from
fbea4e7 to
c2370cf
Compare
|
@14rcole The tests hung up on Jenkins. I had to cancel the job. |
|
[test] |
|
That's strange. The CentOS 8 PR is also failing for reasons I can't determine |
|
[test] |
2 similar comments
|
[test] |
|
[test] |
Signed-off-by: Ryan Cole <rycole@redhat.com>
14rcole
force-pushed
the
openstack-galaxy
branch
from
c2370cf to
fbe35d0
Compare
|
@14rcole I don't see any issue on GitHub relating to this PR. |
|
Fixes #1367 |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted this role while perfecting the automation for converting the roles. After running the scripts, you still have to run
molecule lint -s dockerin the role directory and fix any errors manually