Move inventory files into roles #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14rcole
force-pushed
the
ansible-inventory
branch
8 times, most recently
from
d6c0a57 to
f0ba7bd
Compare
|
[test] |
2 similar comments
|
[test] |
|
[test] |
|
@samvarankashyap #1409 is dependent on this |
|
@14rcole I see the build is failing ... |
14rcole
force-pushed
the
ansible-inventory
branch
from
f0ba7bd to
54da549
Compare
|
[test] |
14rcole
force-pushed
the
ansible-inventory
branch
from
54da549 to
e8318a0
Compare
|
ci-linchpin-messageBus-trigger build #414: FAILURE: https://jenkins-linchpin.cloud.privileged.psi.redhat.com/job/ci-linchpin-messageBus-trigger/414/ |
Signed-off-by: 14rcole <rycole@redhat.com>
14rcole
force-pushed
the
ansible-inventory
branch
from
e8318a0 to
2f37385
Compare
|
ci-linchpin-messageBus-trigger build #415: FAILURE: https://jenkins-linchpin.cloud.privileged.psi.redhat.com/job/ci-linchpin-messageBus-trigger/415/ |
|
[merge] |
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the provider-specific inventory generation logic into each role, and updates the remaining inventory generation logic to search for
inventory.pyfiles therein. This allows users to write their own roles without creating a linchpin PR for inventory generation.I know this is a huge PR, but unfortunately none of it could be broken down into multiple commits. Most of the changes are the result of moving the inventory files into the roles, but because of some necessary updates to things like import paths, git won't show it as just a moved file