Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libvirt differentiate ip #1280

Merged
merged 8 commits into from
Aug 20, 2019

Conversation

JunqiZhang0
Copy link
Contributor

Fix #1248

@adl-bot
Copy link

adl-bot commented Aug 15, 2019

Can one of the admins verify this patch?

@adl-bot
Copy link

adl-bot commented Aug 19, 2019

@samvarankashyap
Copy link
Contributor

@JunqiZhang0
Failed unit tests

        }
    }, 
    "msg": "non-zero return code", 
    "rc": 1, 
    "start": "2019-08-19 15:05:34.495968", 
    "stderr": "", 
    "stderr_lines": [], 
    "stdout": "./linchpin/FilterUtils/FilterUtils.py:22:1: E302 expected 2 blank lines, found 1\n./linchpin/FilterUtils/FilterUtils.py:28:1: E302 expected 2 blank lines, found 1", 
    "stdout_lines": [
        "./linchpin/FilterUtils/FilterUtils.py:22:1: E302 expected 2 blank lines, found 1", 
        "./linchpin/FilterUtils/FilterUtils.py:28:1: E302 expected 2 blank lines, found 1"
    ]
} 

@JunqiZhang0
Copy link
Contributor Author

[test]

@adl-bot
Copy link

adl-bot commented Aug 19, 2019

@adl-bot
Copy link

adl-bot commented Aug 19, 2019

@JunqiZhang0
Copy link
Contributor Author

[test]

@adl-bot
Copy link

adl-bot commented Aug 19, 2019

@adl-bot
Copy link

adl-bot commented Aug 19, 2019

@JunqiZhang0
Copy link
Contributor Author

[test]

@adl-bot
Copy link

adl-bot commented Aug 19, 2019

@JunqiZhang0
Copy link
Contributor Author

[test]

@adl-bot
Copy link

adl-bot commented Aug 20, 2019

@adl-bot
Copy link

adl-bot commented Aug 20, 2019

Copy link
Contributor

@samvarankashyap samvarankashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunqiZhang0
Copy link
Contributor Author

[merge]

@adl-bot adl-bot merged commit 5d43c65 into CentOS-PaaS-SIG:develop Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When Libvirt instances have multiple IPs it would be great to label which is public vs private
3 participants