Fix release #1127
Fix release #1127
Conversation
config/Dockerfiles/release-notes.py
Outdated
| return changes | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: we should be leaving two blank lines between functions
|
@skatlapa could you squash the changes into single commit, please. |
…evelop Fix release bug fix nit fix nit nit Update release-notes.py add space
|
@14rcole btw.. would we have more than one label that the other functions don't catch? If yes, we could remove break |
|
@skatlapa yes, but I don't see how that enables us to remove break |
|
@14rcole break would only catch one flag that isn't 'release', if we need to catch other flags too then we need to remove break. Also, I think we should probably adjust the function to not to return empty stack(changes) or return 'None'. |
|
Let's merge after this is successful - https://jenkins-continuous-infra.apps.ci.centos.org/view/Linchpin/job/ci-linchpin/1433/ But looks like Travis build failed, looking more |
|
[test] |
|
ci-linchpin-messageBus-trigger build #59450: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/59450/ |
|
@samvarankashyap @14rcole do you know why Travis failed? Jenkins is good and codewise everything looks good. |
|
@skatlapa it looks like travis passed |
|
@14rcole there was an unused var that would've to cause some linting/pyflake error, removed, and rest lgtm. I'll merge once the Jenkins build completes |
|
[test] |
|
[merge] |
|
ci-linchpin-messageBus-trigger build #59451: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/59451/ |
|
ci-linchpin-messageBus-trigger build #59452: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/59452/ |
No description provided.