Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Inventory Generation failures when var is not a string #1036

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix Inventory Generation failures when var is not a string #1036

merged 1 commit into from
Mar 20, 2019

Conversation

14rcole
Copy link
Contributor

@14rcole 14rcole commented Mar 20, 2019

Fixes #1026

@14rcole
Fix Inventory Generation failures when var is not a string
cc2a54a 
Signed-off-by: Ryan Cole <rycole@redhat.com>
@14rcole 14rcole requested a review from samvarankashyap March 20, 2019 11:38
@14rcole
Copy link
Contributor Author

14rcole commented Mar 20, 2019

@wainersm This should fix the problem you had

@adl-bot
Copy link

adl-bot commented Mar 20, 2019

ci-linchpin-messageBus-trigger build #59234: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/59234/

@14rcole
Copy link
Contributor Author

14rcole commented Mar 20, 2019

[test]

samvarankashyap
samvarankashyap approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@samvarankashyap samvarankashyap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subjected to the tests: LGTM

@adl-bot
Copy link

adl-bot commented Mar 20, 2019

ci-linchpin-messageBus-trigger build #59235: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/59235/

@14rcole
Copy link
Contributor Author

14rcole commented Mar 20, 2019

[merge]

@adl-bot adl-bot merged commit aa8891b into CentOS-PaaS-SIG:develop Mar 20, 2019
@14rcole 14rcole added this to the v1.7.3 milestone Mar 20, 2019
@14rcole 14rcole deleted the layout-boolean branch March 20, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvarankashyap samvarankashyap samvarankashyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@14rcole @adl-bot @samvarankashyap