Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/quality of life improvements #21

Merged
merged 6 commits into from
Jun 1, 2020

Conversation

Cellivar
Copy link
Owner

@Cellivar Cellivar commented Jun 1, 2020

This bundles up a handful of small changes that makes the application easier to build and run.

  • Warning hunt to clean up some existing warnings that have crept in.
  • Adds AdminList configuration option, a comma-separated list of emails that are admin accounts
    • This partially implements Admin accounts #4 but the actual admin-y pages need to be added to complete it.
  • Adds unit tests for AdminList related functions
  • Extraneous forward slashes are dropped from the end of URL lookups, making Template URLs #6 easier to implement
  • Fix the dockerfile to use the right sdk image for building.
  • Fix the default okta API urls.

Cellivar added 6 commits May 30, 2020 17:31
Apparently this is a common problem with some applications automatically appending a forward slash when copy/pasting links or something similar.
Apparently the 'default' in these URLs has to do with Custom Auth Servers and throws an error if you haven't paid for or set that up. Remove it wholesale until I get around to implementing support for custom auth servers.
@Cellivar Cellivar merged commit e8ff427 into master Jun 1, 2020
@Cellivar Cellivar deleted the feature/quality-of-life-improvements branch June 1, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant