Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands
test_readfile
and addstest_{createdp,pushtopandas}
.At present, since:
it's hard to build small artificial test cases where the expected behavior can be determined by visual inspection. On the other hand, refactoring / cleaning up the code without adequate test coverage can lead to regression. For this reason, the approach adopted in this PR is to use the current examples as a reference for the expected results, which basically amounts to assuming that the current code (which generated those examples) is correct. Note that I've added
tracks.csv
files since they were necessary for testing thepushtopandas
module. They have been generated with a quick hack: