Added get_orb_similarity_matrix to wrangler.py #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbluque
requested changes
Feb 18, 2022
There was a problem hiding this comment.
this is awesome, thanks @kamronald !
Can you just make the minor changes suggested and push again to your fork so the come up here.
Define the matrix transpose value in the loop. Edit function title and documentation
…into corr_sim_metrics
lbluque
approved these changes
Mar 1, 2022
|
Thanks @kamronald, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-->
Additional dependencies introduced (if any)
TODO (if any)
Checklist
Run pycodestyle and flake8
on your local machine.
Run pydocstyle on your code.