Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto detect text cursor in mousemove, make it configurable #12

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

CatsJuice
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented Jul 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ipad-cursor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2023 6:41am

@Jannchie
Copy link
Contributor

Jannchie commented Jul 8, 2023

Thanks for the quick reply! I tested this branch and it has been working mostly well.

However, I found that the code block on the home page does not change the type of the cursor completely properly.
Perhaps it would be better to apply data-cursor="text" to the code block?

@CatsJuice
Copy link
Owner Author

Thanks for the quick reply! I tested this branch and it has been working mostly well.

However, I found that the code block on the home page does not change the type of the cursor completely properly.

Perhaps it would be better to apply data-cursor="text" to the code block?

Yes, that’s why I haven’t merge this PR. Apply data-cursor="text" to <code> should resolve the problem, I wonder if there is a better solution.

@CatsJuice CatsJuice merged commit eaad348 into main Jul 8, 2023
@CatsJuice CatsJuice deleted the feat/automatically-add-data-cursor-text branch July 8, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants