Skip to content

Commit

Permalink
Bugfix: Save sorted document groups
Browse files Browse the repository at this point in the history
  • Loading branch information
CatoTH committed Jan 21, 2025
1 parent 62cb5ce commit f8d5b63
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions History.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Next to the status-dropdown for motions and amendments, there is now a link to a reference page, explaining the uses of these different statuses.
- Bugfix: If a voting was set to be shown in a motion view, it was not shown on the dedicated voting page anymore.
- Bugfix: Sorting document groups on the separate document page did not work properly.
- Bugfix: Some tabs opened in parallel could interfere with logging in using a second factor.
- Bugfix: When logging in using a second factor, one would always end up in the site home page, not the page where one started the login.
- Bugfix: Some empty paragraphs could lead to problems with creating amendments if only one paragraph could be changed.
Expand Down
5 changes: 3 additions & 2 deletions controllers/PagesController.php
Original file line number Diff line number Diff line change
Expand Up @@ -534,10 +534,11 @@ public function actionDocuments(): ResponseInterface
foreach ($this->consultation->fileGroups as $fileGroup) {
if (isset($idPosition[$fileGroup->id])) {
$fileGroup->position = $idPosition[$fileGroup->id];

return new RedirectResponse(UrlHelper::createUrl('/pages/documents'));
$fileGroup->save();
}
}

return new RedirectResponse(UrlHelper::createUrl('/pages/documents'));
}

return new HtmlResponse($this->render('documents'));
Expand Down
1 change: 1 addition & 0 deletions views/consultation/index_layout_agenda.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
$prefix = ($isResolutionList ? Yii::t('con', 'resolutions') . ': ' : '');
echo '<h2 class="green">' . $prefix . Html::encode($agendaItem->title) . '</h2>';
echo '<ul class="motionList motionListStd motionListBelowAgenda agenda' . $agendaItem->id . '">';
echo '<!-- Test -->';
$itemImotions = MotionSorter::getSortedIMotionsFlat($consultation, $itemImotions);
foreach ($itemImotions as $imotion) {
if (is_a($imotion, Motion::class)) {
Expand Down

0 comments on commit f8d5b63

Please sign in to comment.