Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling group list may trigger group list swipe #699

Closed
TheLastProject opened this issue Dec 24, 2021 · 3 comments
Closed

Scrolling group list may trigger group list swipe #699

TheLastProject opened this issue Dec 24, 2021 · 3 comments
Labels
common: frequent Affects or can be seen by most users regularly or impacts most users' first experience severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: bug Something isn't working

Comments

@TheLastProject
Copy link
Member

Obviously, a group switch shouldn't occur when moving the group list in the main activity to see what groups there are. The group switching listener is probably on the wrong UI level.

video_2021-12-25_00-03-21.mp4
@TheLastProject TheLastProject added the type: bug Something isn't working label Dec 24, 2021
@Altonss
Copy link
Contributor

Altonss commented Jan 13, 2022

I have a similar issue, when scrolling up and down in the list of cards (in a tab), sometimes this triggers a tab change. I don't know if it's related but it might be some sensibility issue...idk

@TheLastProject
Copy link
Member Author

No, that's another issue. The swiping thing shouldn't respond when you're moving through the group list, your sensitivity thing, well, feel free to make a MR to suggest other values: https://github.com/TheLastProject/Catima/blob/eb38d0a8aa811f420d5717d16802a602d4feae5f/app/src/main/java/protect/card_locker/MainActivity.java#L605-L650

@TheLastProject TheLastProject added common: frequent Affects or can be seen by most users regularly or impacts most users' first experience severity: major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 5, 2022
@TheLastProject
Copy link
Member Author

This is "fixed" in #1296 by removing the group swipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: frequent Affects or can be seen by most users regularly or impacts most users' first experience severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants