Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable group swiping #1089

Closed
SomeDeveloping opened this issue Oct 15, 2022 · 4 comments
Closed

Add an option to disable group swiping #1089

SomeDeveloping opened this issue Oct 15, 2022 · 4 comments
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented

Comments

@SomeDeveloping
Copy link

Issue also mentioned here : #699

While scrolling vertically through the cards, it often switches to other groups. It's due to the natural gesture not being perfectly vertical, especially when using the phone with one hand.

I don't use the horizontal swipe as directly selecting a group is quicker and more straightforward. It's the same for people around me.

Seeing this swiping feature is not a necessity, and even a nuisance in some cases : could you add an option to disable it ?

It would also solve #699

@Altonss
Copy link
Contributor

Altonss commented Oct 15, 2022

ssue also mentioned here : #699

While scrolling vertically through the cards, it often switches to other groups. It's due to the natural gesture not being perfectly vertical, especially when using the phone with one hand.

As you are not the only one experiencing this issue (I have the same problem), maybe we could just fix the issue by tweaking the parameter mentioned in #699 to ensure the horizontal scrolling is not triggered that fast.

@SomeDeveloping
Copy link
Author

SomeDeveloping commented Oct 15, 2022

Still, it wouldn't solve the major issue from #699 title.

I'm solely a user and not a programmer, sorry. So I'm proposing an easier (?) compromise in case the issue was left there : removing a non-essential buggy feature.

@TheLastProject TheLastProject added the state: consensus-needed A consensus needs to be reached before this can be implemented label Oct 17, 2022
@TheLastProject
Copy link
Member

It is not a fix for #699 (comment) though, it's a workaround, the problem still exists.

I really don't like the idea of "just add a switch to disable every feature that doesn't work 100% perfectly" because before you know you end up with 200 settings in the app and nobody can find the setting they want (and a super complex codebase with if/else checks literally everywhere with likely many bugs). In this one case it might be possible as an accessibility feature for people who have motor issues, but it first needs deciding for what to do about the LoyaltyCardViewActivity screen as you can only switch between barcode and photos there by swiping currently.

@TheLastProject
Copy link
Member

This is "fixed" in #1296 by removing the group swipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented
Projects
None yet
Development

No branches or pull requests

3 participants