build Android version part-01 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
We can support Android build in this way for the time being. As for the so-called security, I don't think it's a special consideration for the project right now, let alone that we don't plan to put it on the app store so we can think about it later. It is from andrei8l andrei8l@e5b4322. You can skip all the tests and merge it because it doesn't have any c++ code and json code. Existing tests don't make sense for this PR either.
Describe the solution
Describe alternatives you've considered
Testing
Additional context
If you're not giving up on your project, get up and approve the workflow 👿.This PR I used the master branch directly, and after this PR, I will work with other branches normally.@Night-Pryanik