Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overhead light to three default shelters #57

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

Night-Pryanik
Copy link

Summary

Content "Added overhead light to three default shelters"

Purpose of change

Three default shelters are completely dark. This is both strange (why there's no light, but computer nearby is working?) and probably confusing for new players.

Describe the solution

Added overhead light to three default shelters.

Describe alternatives you've considered

None.

Testing

Debug-spawned locations in the game.

Additional context

изображение

изображение

@meladath
Copy link

I believe the original reason behind this was that it reduced the chances of people getting attacked by any hostile mobs within sight of the shelter since the windows/curtains are open.

Could be completely wrong on that though...

@Night-Pryanik
Copy link
Author

Ok, then I think it would be better to make all windows in these shelters spawn with closed curtains.

@NetSysFire
Copy link

Would fit super well into upstream, too. Nice catch. I wonder if, using the new power grid feature, one can connect the solar panel on the roof with the computer and the lights yet in the mapgen definitions.

@Night-Pryanik Night-Pryanik merged commit 101e7b6 into master Apr 17, 2023
@Night-Pryanik Night-Pryanik deleted the lighted-shelters branch April 17, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants