Use ES2015 classes instead of having prototype-based functions #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
…rectly by a resourceblock page Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Solution was to not execute scripts which have already been executed An algorithm, which shows tabs has also been refactored Empty constructors in filters.js file have been deleted catblock.js and catblock.css files have been moved Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
…fari 6.x Signed-off-by: Tomáš Taro <tomas@getadblock.com>
…pport for already unsupported versions of Safari by Apple Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
|
@kpeckett I have just figured out, that I might have missed to add some arguments to some methods as in an example below. As you can see, there is missing an I will compare the code from master branch and this branch and will let you know in advance, when you can start reviewing this PR. |
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
itskdog
reviewed
Oct 22, 2016
| throw new Error("Implemented by subclass. Call callback with up-to-date listings."); | ||
| } | ||
| }; | ||
|
|
||
| } | ||
|
|
||
| // Channel containing hard coded cats loaded from disk. | ||
| // Subclass of Channel. |
There was a problem hiding this comment.
Second comment not needed as it is now explicit in the code.
| @@ -238,23 +239,26 @@ AprilFoolsCatsChannel.prototype = { | |||
| L(109, 385, "tall6.jpg") | |||
| ]); | |||
| } | |||
| }; | |||
|
|
|||
| } | |||
|
|
|||
|
|
|||
| // Abstract base class for Flickr-based Channels. | |||
| // Subclass of Channel. | |||
| @@ -301,55 +305,51 @@ FlickrChannel.prototype = { | |||
| } | |||
| return result; | |||
| } | |||
| }; | |||
| } | |||
|
|
|||
| // Channel pulling from Flickr search results. | |||
| // Subclass of FlickrChannel. | |||
| var that = this; | ||
| this._api("flickr.photos.search", { text: this._query }, function(resp) { | ||
| callback(that._toListings(resp.photos)); | ||
| }); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| // Channel pulling from a Flickr photoset. | ||
| // Subclass of FlickrChannel. |
There was a problem hiding this comment.
I'll just let you find the rest. Do a git grep subclass or something.
There was a problem hiding this comment.
@kpeckett I've removed all those comments.
| if (this._subscriptions[id].subscribed) { | ||
| //if forceFetch, set the last update timestamp of the malware to zero, so it's updated now. | ||
| if (forceFetch) { | ||
| this._subscriptions.malware.last_update = 0; |
There was a problem hiding this comment.
Was this completely removed? I can't tell where it's moved to.
There was a problem hiding this comment.
@kpeckett Nope, it wasn't.
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will practically improve readability of the code.
An algorithm for showing tabs in Options has also been reworked, which as a result improves performance.
@kpeckett Could you please review the changes I've made? Thanks 😀