fix: compilation on 32bit platforms #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32bit platforms passing `long` to `data_t` causes ambiguity, because it doesn't map directly into any of the types held by `data_t`.
|
I would say that I don't see the value in supporting armhf, or other 32bit platforms, but as the change is so simple I don't object to it |
Julusian
changed the title
Julusian
pushed a commit
that referenced
this pull request
Sep 16, 2024
I was just thinking maybe some cheaper ARM boxen that don't have proper 64 bit Linux support can benefit from it. Otherwise, I was of the same frame of mind as you, since this is a very small change, why not. Thanks for accepting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32bit platforms passing
longtodata_tcauses ambiguity, because it doesn't map directly into any of the types held bydata_t.