Some corrections(Json and correct order of function calls) and some improvements(saveAs,Open). #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…combobox.html#setView, Note: If you want to use the convenience views (like QListWidget, QTableWidget or QTreeWidget), make sure to call setModel() on the combobox with the convenience widgets model before calling this function. File RundowWidget.cpp: open on dir of the last opened file, to avoid going to the entire path again to open a file on the same directory. File RundownTreeWidget.cpp: on save as, open folder of the active Rundown or HomeDir if active == DEFAULT_NAME Files src/Core/Commands/TemplateCommand.cpp, src/Core/Commands/TemplateCommand.h: Uses QT Json library to convert to single line json. Avoids errors on new lines and other caracters that could break the update function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File DeviceFilterWidget: Correction based on https://doc.qt.io/qt-6/qcombobox.html#setView
Note: If you want to use the convenience views (like QListWidget, QTableWidget or QTreeWidget), make sure to call setModel() on the combobox with the convenience widgets model before calling this function.
File RundowWidget.cpp: open on dir of the last opened file, to avoid going to the entire path again to open a file on the same directory.
File RundownTreeWidget.cpp: on save as, open folder of the active Rundown or HomeDir if active == DEFAULT_NAME
Files src/Core/Commands/TemplateCommand.cpp, src/Core/Commands/TemplateCommand.h: Uses QT Json library to convert to single line json. Avoids errors on new lines and other caracters that could break the update function call.