-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kurtosis and skewness #124
Conversation
Hey @ohasselblad, it would be nice if you add some tests for these functions. |
ok @rochoa added them, but the functions aren't being found in the test. It must be in my naming convention. Should I not be bundling in functions that do two different things in one file? |
I did a couple of changes:
|
|
||
With dist As ( | ||
SELECT random()::numeric As val | ||
FROM generate_series(1,5000000) t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test with a lower range? Testing with such a big one means the test is very slow.
What is the minimum range we can use to validate these functions?
👍 thanks for all the input, @rochoa :) |
Adding these measures as they could be used in pecan analysis
To do: still need to add tests