Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kurtosis and skewness #124

Merged
merged 10 commits into from
Sep 7, 2015
Merged

Add kurtosis and skewness #124

merged 10 commits into from
Sep 7, 2015

Conversation

andy-esch
Copy link
Contributor

Adding these measures as they could be used in pecan analysis

To do: still need to add tests

@rochoa
Copy link
Contributor

rochoa commented Sep 2, 2015

Hey @ohasselblad, it would be nice if you add some tests for these functions.

@andy-esch
Copy link
Contributor Author

ok @rochoa added them, but the functions aren't being found in the test. It must be in my naming convention. Should I not be bundling in functions that do two different things in one file?

@rochoa
Copy link
Contributor

rochoa commented Sep 3, 2015

I did a couple of changes:

  • fix the symlink: that was preventing to make the functions available during tests
  • raise the min messages to not validate notices


With dist As (
SELECT random()::numeric As val
FROM generate_series(1,5000000) t
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test with a lower range? Testing with such a big one means the test is very slow.

What is the minimum range we can use to validate these functions?

@andy-esch
Copy link
Contributor Author

👍 thanks for all the input, @rochoa :)

rochoa pushed a commit that referenced this pull request Sep 7, 2015
@rochoa rochoa merged commit c6cdaea into master Sep 7, 2015
@rochoa rochoa deleted the add-kurtosis branch September 7, 2015 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants