Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] split for validation #369

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[fix] split for validation #369

merged 1 commit into from
Mar 17, 2023

Conversation

hzwer
Copy link
Contributor

@hzwer hzwer commented Mar 16, 2023

In the summarize dataset, the judgment statement for the dataset division is wrong, which will cause the validation set to be the full dataset, and most of the GPU time will be used for model validation

@hzwer
Copy link
Contributor Author

hzwer commented Mar 16, 2023

image

The part pointed by the arrow is the validation consumption time

@LouisCastricato
Copy link
Contributor

Hey can you please write a description? Otherwise we cannot merge.

@hzwer
Copy link
Contributor Author

hzwer commented Mar 17, 2023

@LouisCastricato Hi, I made some additions. The modified code is a single word.

@hzwer hzwer changed the title Fix split for validation [fix] split for validation Mar 17, 2023
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @hzwer!

@jon-tow jon-tow merged commit 2f90ba0 into CarperAI:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants