Add tokenizer config #189
Merged
Add tokenizer config #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-tow
approved these changes
Jan 14, 2023
| :type truncation_side: str | ||
| """ | ||
|
|
||
| tokenizer_path: str |
There was a problem hiding this comment.
(Thinking out loud on usability): I feel like we could make this optional and default to using the model_path to load the tokenizer out of AutoTokenizer.from_pretrained in the base trainer)
There was a problem hiding this comment.
Also the tokenizer_ part seems redundant being already in a TokenizerConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes
https://wandb.ai/sorry/trlx/reports/Difference-truncation_side-left-right--VmlldzozMzMwNTk5