#209 Add (optional) tooltips to icons #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Adds optional hover tooltips to icon buttons, toggled by the new showIconTooltips prop, with customizable text via localisation.
- Introduce and propagate
showIconTooltipsprop through types and components (defaulting tofalseinJsonEditor). - Add new localisation keys (
TOOLTIP_COPY,TOOLTIP_EDIT,TOOLTIP_DELETE,TOOLTIP_ADD). - Update
EditButtonsto conditionally rendertitleattributes, and document usage in README and demo.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #209
Adds optional tooltips for icons -- must be enabled by the
showIconTooltipsprop.Text for the tooltips can be customised using localisations.