Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add induced_subgraph functionality #499

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

askorupka
Copy link
Collaborator

This PR introduces induced_subgraph functionality to match Graphs interface.

As per @CarloLucibello comment in the #495

Notice that we already have the very similar function sample_neighbors in GNNGraphs.jl. Let's implement induced_interface as well in order to be Graphs.jl compliant.

@askorupka
Copy link
Collaborator Author

I'm aware that we shouldn't assume ndata are called x and also extract edata & I've marked it as ##TODO
But I've got a question related to this discussion #497 (comment)
@CarloLucibello what is the best way to implement it as getobs doesn't work

julia> getobs(g.ndata, 1)
ERROR: UndefVarError: `getobs` not defined
Stacktrace:
 [1] top-level scope
   @ REPL[8]:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant