Update req ~> 0.4.0; fix warning for logger and req retry #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliphaunte
commented
Dec 14, 2023
| @@ -237,7 +237,7 @@ defmodule AbsintheClient do | |||
|
|
|||
| iex> req = | |||
| ...> Req.new(base_url: "http://localhost:4002/", auth: {:bearer, "invalid-token"}) | |||
| ...> |> AbsintheClient.attach(retry: :never) | |||
| ...> |> AbsintheClient.attach(retry: false) | |||
There was a problem hiding this comment.
Warning from req requests this change, does not seem like it should affect anything
|
Thanks for this, and sorry for the delay! 🍬 🍫 🍭 🍰 🍨 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several packages I am using now use req 0.4.0 as default, and I realized this package is locked at 0.3.0
There are some breaking changes with how headers are handled in 0.4, but we can pass
config :req, legacy_headers_as_lists: trueto bypass these changes until req 1.0I wanted to go ahead and update, but I had a lot of trouble figuring out where the changes broke and did not have enough time to do a deep dive. The bypass should work for the foreseeable future.
https://hexdocs.pm/req/changelog.html#v0-4-0-2023-09-01
Tests are passing with the updated config
Thanks for the great package!