Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cicd workflows to publish release and snapshot/prerelease tags slightly differently. #109

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

greinard
Copy link
Collaborator

@greinard greinard commented Sep 8, 2023

Overview

This change is necessary to ensure that snapshot/pre-release tags do not result in populating the latest version of the library. Otherwise, feature branch pre-releases can get picked up as the latest version.

Security

REMINDER: All file contents are public.

  • I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.
    • Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
    • There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
  • These changes do not introduce any security risks, or any such risks have been properly mitigated.

Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.

  • This change adds a further limitation to publishing to help ensure that feature branch pre-releases are not picked up as the latest version of the library from npm.

Checklist

Testing

This change is related to build/deploy config, not the app functionality itself. Testing of the build/deploy config will be performed as soon as changes are available on main.

Documentation

N/A - Other than a possible update to the README to describe how to use the Snapshot.ps1 script.

@greinard greinard merged commit 1c99f6b into main Sep 8, 2023
@greinard greinard deleted the AdjustCicd branch September 8, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants