Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1-287: Update the front end to inflation changes #81

Merged
merged 2 commits into from
Oct 9, 2024
Merged

L1-287: Update the front end to inflation changes #81

merged 2 commits into from
Oct 9, 2024

Conversation

youPickItUp
Copy link

Update inflation calculations:

  • add type augmentation to type new API methods
  • fetch inflation from backend and simplify frontend logic

@youPickItUp
Copy link
Author

I've asked for review a bit too early. I still have to figure out how to add custom runtime methods to polkadot API - I'll probably copy azero.dev code 🤞

@youPickItUp youPickItUp force-pushed the L1-287-update-the-front-end-to-inflation-changes branch from eac4dbf to 3307c4e Compare October 9, 2024 08:05
@youPickItUp
Copy link
Author

I've asked for review a bit too early. I still have to figure out how to add custom runtime methods to polkadot API - I'll probably copy azero.dev code 🤞

Done ✔️

kostekIV
kostekIV approved these changes Oct 9, 2024
View reviewed changes
Copy link

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculations look good

jalooc
jalooc approved these changes Oct 9, 2024
View reviewed changes
Copy link

@jalooc jalooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/library/Hooks/useInflation/index.tsx Show resolved Hide resolved
@youPickItUp youPickItUp force-pushed the L1-287-update-the-front-end-to-inflation-changes branch from 3307c4e to 72e15d5 Compare October 9, 2024 11:56
@youPickItUp youPickItUp force-pushed the L1-287-update-the-front-end-to-inflation-changes branch from 72e15d5 to 42d9cfa Compare October 9, 2024 16:23
@youPickItUp youPickItUp merged commit b2c7163 into master Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalooc jalooc jalooc approved these changes

@kostekIV kostekIV kostekIV approved these changes

@Marcin-Radecki Marcin-Radecki Awaiting requested review from Marcin-Radecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youPickItUp @jalooc @kostekIV