A0-2156-stop-the-world-calls

.github/workflows/_check-excluded-packages.yml

@@ -47,15 +47,31 @@ jobs:
           packages="${packages//'%0A'/$'\n'}"
           for p in ${packages[@]}
           do
-            # skip checking the contracts for now
-            if [ $p = "contracts/adder" ] || [ $p = "contracts/poseidon_host_bench" ]
-            then
-              continue
-            fi
             echo "Checking package $p..."
             pushd "$p"
+            rustup component add clippy rustfmt
+            rustup target add wasm32-unknown-unknown
+
+            rustup component add rust-src --toolchain nightly-2022-10-30-x86_64-unknown-linux-gnu
+            cargo install cargo-dylint dylint-link
+            cargo install cargo-contract --vers ^2.0 --force --locked
+
+            if [ $p = "contracts/adder" ] ||
+               [ $p = "contracts/poseidon_host_bench" ] ||
+               [ $p = "contracts/access_control" ] ||
+               [ $p = "contracts/adder" ] ||
+               [ $p = "contracts/button" ] ||
+               [ $p = "contracts/game_token" ] ||
+               [ $p = "contracts/marketplace" ] ||
+               [ $p = "contracts/simple_dex" ] ||
+               [ $p = "contracts/ticket_token" ] ||
+               [ $p = "contracts/wrapped_azero" ]
+            then
+               cargo contract check
+            else
+               cargo clippy -- --no-deps -D warnings
+            fi
             cargo fmt --all --check
-            cargo clippy -- --no-deps -D warnings
             popd
           done
 

.github/workflows/contracts-deploy.yml

@@ -2,6 +2,8 @@
 name: contracts-e2e-tests-and-deploy
 
 on:
+  pull_request:
+    types: [labeled]
   workflow_call:
 
 # DO NOT TOUCH THIS !
@@ -51,7 +53,14 @@ jobs:
              - '.github/workflows/contracts-deploy.yml'
 
   build-and-deploy-contracts:
-    needs: [detect-contracts-changes]
+    # TODO: e2e test are flaky AF
+    # and they block the deployment
+    # which in turns stalls development
+    # as frontend developers rely heavily on the devnet environment.
+    # Therefore we made an executive decision to deploy to the devnet
+    # regardless of the contracts e2e tests status.
+    # Once fixed this dependency can be brough back
+    # needs: [detect-contracts-changes]
     name: Deploy contracts on devnet
     if: >
       (needs.changes.outputs.button == 'true' &&
@@ -60,7 +69,7 @@ jobs:
       (github.event_name == 'pull_request' &&
        github.event.action == 'labeled' &&
        github.event.label.name == '[AZERO] DEPLOY-CONTRACTS')
-    runs-on: ubuntu-20.04
+    runs-on: self-hosted
     steps:
       - name: Checkout repo
         uses: actions/checkout@v3
@@ -115,7 +124,6 @@ jobs:
       - name: Run deploy.sh script
         shell: bash
         run: |
-          . "$HOME/.cargo/env"
           source contracts/env/${{ env.CONTRACTS_ENVFILE }} && ./contracts/scripts/deploy.sh
 
       - name: Update ABI arifacts and addresses.json file in the S3 bucket

Cargo.toml

@@ -30,6 +30,7 @@ exclude = [
     "contracts/simple_dex",
     "contracts/ticket_token",
     "contracts/wrapped_azero",
+    "contracts/shared_traits",
     "e2e-tests",
     "flooder",
     "fork-off",