Rework Dockerfile in multi-stages and provide a stage where cardano-node & ogmios are bundled together #58
Conversation
There was a problem hiding this comment.
Not sure we can restrict Dockerhub builds to a specific build target so we might as well disable builds in Dockerhub and do everything with Github actions.
Looks like you can do it with custom build hooks
|
So, this now work fine: $ docker build --target ogmios .
$ docker build --target cardano-ogmios-node .In the case of the latter, one can then: $ docker run --rm --name cardano-node-ogmios -e NETWORK=testnet -p 1337:1337 ...which starts Ogmios + a node. Works with mainnet, testnet and staging aaaaand, seems like the node is syncing fine (after struggling a good bit, finally found out that the runtime image needs to have I still need to adjust the user manual and maybe some bits in the CI accordingly but, it's mostly there 🐳 |
…ode & ogmios are bundled together One can still fallback to the previous behavior by running 'docker build . --target ogmios'; The full build now however also builds a cardano-node.
KtorZ
force-pushed
the
KtorZ/44/cardano-node-ogmios-docker
branch
from
5769470 to
362bbdd
Compare
KtorZ
force-pushed
the
KtorZ/44/cardano-node-ogmios-docker
branch
3 times, most recently
from
2df7566 to
371a65f
Compare
…stead of docker hub)
…gmios in the user-guide.
KtorZ
force-pushed
the
KtorZ/44/cardano-node-ogmios-docker
branch
from
371a65f to
c4838bc
Compare
| ```console | ||
| $ docker build --target cardano-node-ogmios --tag ktorz/cardano-node-ogmios:latest . | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Note that this is the default build target for the image, but --target cardano-node-ogmios can be set explicitly
- Make the separation between ogmios and cardano-node-ogmios clearer - Give better run instructions, and build instructions - Review general grammar and wording
The main rationale is that having it scoped in sub-directory is more painful than useful and causes issue with tools, in particular the docker buildkit.
KtorZ
force-pushed
the
KtorZ/44/cardano-node-ogmios-docker
branch
from
61f2fca to
2497f51
Compare
Fixes #44
4fea04a
📍 Rework Dockerfile in multi-stages and provide a stage where cardano-node & ogmios are bundled together
One can still fallback to the previous behavior by running 'docker build . --target ogmios'; The full build now however also builds a cardano-node.
362bbdd
📍 Adjust Dockerfile to use cabal only, and pre-build Ogmios during the setup.
b98ba18
📍 Fix ARG / scheme for cardano-node-ogmios build stage
ac06142
📍 Add more debug capabilities to wait-for-sync script.
96f1ad8
📍 Fix Dockerlint warnings & errors.
69401b5
📍 Add workflow to build and push Docker images using github actions (instead of docker hub)
c4838bc
📍 Include instructions about building/running standalone cardano-node-ogmios in the user-guide.