Since tip #176
Closed
Since tip #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: cardano-node direct integration.
Unfortunately, we have to use an MVar to pass return value from the client since 'connectTo' swallows whatever the client is trying to return. This is unfortunate, but also pretty safe given that we are guaranteed to either: exit with an exception or put a tip in the MVar before attempting to take it.
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Thread new 'Since' type through the app and add few unit test for the CLI.
📍 half of a fetchTip
📍 Implement and use a 'fetchTip' client for Ogmios.
TODO: cardano-node direct integration.
📍 Implement FetchTip for cardano-node
Unfortunately, we have to use an MVar to pass return value from the client since 'connectTo' swallows whatever the client is trying to return. This is unfortunate, but also pretty safe given that we are guaranteed to either: exit with an exception or put a tip in the MVar before attempting to take it.