Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecordProcessor API change (BACKWARD-INCOMPATIBLE CHANGE) #606

Closed
ldhasson opened this issue May 17, 2021 · 0 comments
Closed

RecordProcessor API change (BACKWARD-INCOMPATIBLE CHANGE) #606

ldhasson opened this issue May 17, 2021 · 0 comments
Labels
bug S1

Comments

@ldhasson
Copy link
Collaborator

ldhasson commented May 17, 2021 •
edited
Loading

The RecordProcessor API needs to allow for exceptions out of start and end methods. This is causing a BREAKING CHANGE in three ways:

  • Code needs to be re-generated since record processors are used internally by Tilda classes
  • If you created your own record processor, youned to update the signature of the "start()" and "end()" methods to throw exceptions.
  • If you use record processors directly, you need to catch those exceptions or propagate them.
@ldhasson ldhasson changed the title RecordProcessor API change RecordProcessor API change (BACKWARD-INCOMPATIBLE CHANGE) May 17, 2021
ldhasson added a commit that referenced this issue May 17, 2021
@ldhasson
#606 made RecordProcessor start/end throw exception
01f5e5a 
- updated processors in the framework
- update code-gen for inline processors in factories
@ldhasson ldhasson closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug S1
Projects
Tilda - Main
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldhasson