Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pack solution arguments for vs code cmd #90

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

Dave-Robertson92
Copy link
Contributor

Purpose

Describe the problem or feature in addition to a link to the issue(s).
closes #88
Also fix for debugging project (clean-debug) as was not re-creating debug folder for testing changes

Approach

changes the vscode task for packing solutions pack arg -ad (allowdelete) to 'true' as 'yes' is no longer accepted and erroring

TODOs

  • Documentation updated (if required)
  • Build and tests successful

@Dave-Robertson92 Dave-Robertson92 added the bug Something isn't working label Nov 10, 2022
@Dave-Robertson92 Dave-Robertson92 self-assigned this Nov 10, 2022
Copy link
Contributor

@tdashworth tdashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dave-Robertson92 Thanks for contributing!

Please could you update the test sample project?

@Dave-Robertson92
Copy link
Contributor Author

@tdashworth done as you commented :)

Copy link
Contributor

@tdashworth tdashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😄

@tdashworth tdashworth changed the title debug/utility fix & pack solution fix for vs code cmd fix: pack solution fix for vs code cmd Nov 10, 2022
@tdashworth tdashworth changed the title fix: pack solution fix for vs code cmd fix: pack solution arguments for vs code cmd Nov 10, 2022
@tdashworth tdashworth merged commit fe1f415 into master Nov 10, 2022
@tdashworth tdashworth deleted the bug88-vscode-packsolution-arg-error branch November 10, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vs code task "packsolution" errors on argument: allow delete when the arg is yes
2 participants