-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent installation of cantera from PyPI #33
Conversation
Alright. I believe this is ready for a review. Curiously,
|
NumPy pulls in MKL, so that's not totally surprising. I think we'd like to link Cantera to MKL as well, but we can fix that in a separate PR. Thanks for taking this on! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice job solving the mystery of how this could result in having Cantera 2.6.0 installed. I guess I shouldn't have been surprised that it was a result of pip
doing something wrong.
@bryanwweber ... let me know if you have anything else to add? Won't merge this myself as this is the first time I'm working on this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a couple of tiny things here
MKL is disabled as a temporary fix of Cantera#29 to resolve Cantera#31. It should be reactivated in a permanent fix.
Starting with Cantera 3.0, the Python test suite is no longer packaged with the Python module. This commit ensures that conda is still able to run the tests.
@bryanwweber ... thanks! Comments should be taken care of. |
When running
pip install
inbuild.sh/.bat
, fetchingcantera
from PyPi needs to be prevented.Closes #31
Closes #30 (via Cantera/cantera#1358)
Circumvents #29 (MKL is disabled)
Output with manually built package:
Other fixes:
ck2yaml
in packagepytest
share/cantera/data
tolibcantera
package