Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some compilation issues and bump to 2.5.0rc1 #973

Merged
merged 6 commits into from
Feb 5, 2021
Merged

Fix some compilation issues and bump to 2.5.0rc1 #973

merged 6 commits into from
Feb 5, 2021

Commits on Feb 4, 2021

  1. Fix MinGW warning about NOMINMAX redefinition

    @speth
    speth committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    623c6df View commit details
    Browse the repository at this point in the history

  2. [SCons] Don't compile Sundials Fortran interface 

    Cantera doesn't use this part of Sundials, and bundling all of these
files into the cantera library leads to linker errors when compiling
with MinGW and on macOS, due to redefinition of symbols like
'F2C_CVODE_matrix'.
    @speth
    speth committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    4f71634 View commit details
    Browse the repository at this point in the history

  3. Fix MinGW warning about CreateFile arguments

    @speth
    speth committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    2639360 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. [SCons] Suppress deprecation warnings caused by Cython 

    The deprecation warnings previously observed only on macOS are also
emitted when using Clang 10.0 on Linux. Also, despite supposedly being
resolved in Cython 0.29.14, I still get these warnings in Cython
0.29.21.
    @speth
    speth committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    066c49a View commit details
    Browse the repository at this point in the history

  2. [SCons] Fix compilation of f77 sample with clang+gfortran 

    Compiling demo_ftnlib.cpp as a shared object (with -fPIC) fixes an
error about being unable to relocate some pthread-related symbol.
    @speth
    speth committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    dc97439 View commit details
    Browse the repository at this point in the history

  3. Bump version to 2.5.0rc1

    @speth
    speth committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5098d78 View commit details
    Browse the repository at this point in the history