Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCons] Skip OpenMP test/sample when omp.h is not available #962

Merged
merged 2 commits into from
Jan 25, 2021
Merged

[SCons] Skip OpenMP test/sample when omp.h is not available #962

merged 2 commits into from
Jan 25, 2021

Conversation

speth
Copy link
Member

@speth speth commented Jan 21, 2021

Changes proposed in this pull request

  • Check for omp.h and skip the running the test and building the sample that require it

If applicable, fill in the issue number this pull request is fixing

Fixes #933

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@bryanwweber bryanwweber merged commit 735c40b into Cantera:main Jan 25, 2021
@speth speth deleted the fix-933 branch May 23, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanwweber bryanwweber bryanwweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cxx-openmp-ignition test fails if OpenMP is not available
2 participants
@speth @bryanwweber