Fix ck2yaml problems with surface reactions / coverages #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An indentation error meant that coverage dependencies weren't being written in the (simpler) case where we don't have to modify the units for the activation energy. Fixes Cantera#956
The old distutils.version.StrictVersion function doesn't understand some modern version strings.
bryanwweber
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ck2yamlck2yaml4.1.0.post1being unparsable byStrictVersionIf applicable, fill in the issue number this pull request is fixing
Fixes #956
Checklist
scons build&scons test) and unit tests address code coverage