Enabling beta = 0. #955
Merged
Enabling beta = 0. #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speth
requested changes
Jan 18, 2021
Comment on lines
1325
to
1326
| else: | ||
| self._beta = 0.0 |
There was a problem hiding this comment.
I don't think it's necessary to set a value for _beta here. This would just have the awkward effect of having the result of build change if it was called a second time (not that this actually happens in practice).
There was a problem hiding this comment.
Okay, thanks @speth. Just went in and corrected that.
speth
approved these changes
Jan 19, 2021
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
betavalue inctml_writer.pytoNone, and checks to see ifbetahas been set to a value that is notNoneto detect an electrochemical reaction.beta = 0.0which resulted in electrochemical reactions withbeta = 0.0not being detected, and therefore handled incorrectly.If applicable, fill in the issue number this pull request is fixing
Fixes #954
Checklist
scons build&scons test) and unit tests address code coverage