Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update CI workflow #946

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Conversation

bryanwweber
Copy link
Member

@bryanwweber bryanwweber commented Nov 24, 2020

Changes proposed in this pull request

  • Version bumps of dependencies in the CI workflow
  • Fix location of Boost libraries on Windows
  • Add tests on Python 3.9 and Ubuntu 20.04
  • Add format specification in Pdep error printout

If applicable, fill in the issue number this pull request is fixing

Fixes #944

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@bryanwweber bryanwweber marked this pull request as draft November 24, 2020 01:35
@ischoegl
Copy link
Member

#944 is still there ... no idea what’s causing that.

@bryanwweber
Copy link
Member Author

bryanwweber commented Nov 24, 2020

Yeah, seems to be something specific to the Conda-Forge SUNDIALS installations. Probably have to debug it locally.

On the plus side, no problems with Python 3.9!

@speth
Copy link
Member

speth commented Dec 5, 2020

I opened #947 to fix #944, but didn't realize that there were other things breaking the CI. I think adding my commit from that PR to this one should put us back into business.

@bryanwweber
Copy link
Member Author

There are some changes here which are also in 68dee92 in #641. Presumably #641 will need to be rebased to drop the commit I pushed to Gandhali's branch once this is merged.

@ischoegl
Copy link
Member

ischoegl commented Dec 7, 2020

🎉 ... looks like CI is back! Are there any other updates planned under this PR?

@bryanwweber bryanwweber marked this pull request as ready for review December 11, 2020 02:47
@bryanwweber
Copy link
Member Author

No, I think this is ready to merge!

@bryanwweber bryanwweber merged commit d8e62ad into Cantera:main Dec 11, 2020
@bryanwweber bryanwweber deleted the update-ci-runners branch December 11, 2020 02:48
@ischoegl
Copy link
Member

👍 ... Excellent - I rebased #949 (which is a trivial fix), #936/#931/#907 (which should be ready after being reviewed by @speth last weekend again), and #921 (not sure about the eventual fate). I don't have any other plans for the moment (I'll still fix trivial issues if they come up and pique my interest - especially if they are based on things I implemented over the last 1 1/2 years).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sundials CI failure for python:test_kinetics.KineticsRepeatability.test_pdep_err
3 participants