Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1D] Fix FlameBase.restore_data bug #943

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Oct 31, 2020

Changes proposed in this pull request

Fix glitch in Sim1D.restore_data and correct docstrings.

If applicable, fill in the issue number this pull request is fixing

Fixes #942

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@ischoegl ischoegl marked this pull request as draft October 31, 2020 13:21
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@speth speth merged commit 85fe532 into Cantera:main Nov 12, 2020
@ischoegl ischoegl deleted the fix-onedim-restore-data branch January 29, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore_data refers to P[0] instead of P
2 participants