Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ck2yaml] Fixed #940 SRI parameter D,E cannot be written into yaml file when they equal to zero #941

Merged
merged 3 commits into from
Dec 5, 2020

Conversation

12Chao
Copy link
Contributor

@12Chao 12Chao commented Oct 15, 2020

As in demonstrated in issue #940, this pull request fixed the problem that the parameter D or E for SRI expression cannot be parsed into yaml file if it equals to 0.

If applicable, fill in the issue number this pull request is fixing

Fixes #940

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

Copy link
Member

@rwest rwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion. Looks good otherwise.

interfaces/cython/cantera/ck2yaml.py Outdated Show resolved Hide resolved
interfaces/cython/cantera/ck2yaml.py Outdated Show resolved Hide resolved
12Chao and others added 2 commits October 19, 2020 10:19
Co-authored-by: Richard West <r.west@northeastern.edu>
Co-authored-by: Richard West <r.west@northeastern.edu>
@speth speth merged commit 3242674 into Cantera:main Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters for SRI expression of Falloff reactions cannot be parsed correctly
4 participants