Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete data files #923

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 28, 2020

"Blessed" data files for regression tests have been moved to test_problems/cxx_samples (see #883), but some obsolete text files are still present in the old locations.

  • combustor: no longer produces output
  • kinetics1: output is not checked (and differs from original output)

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

Data files for regression tests have been moved to test_problems/cxx_samples.
Two reference output files (for combustor and kinetics1) were left behind that
are no longer relevant, as there is either no output or output has changed.
@speth speth merged commit 54d1fd7 into Cantera:main Aug 31, 2020
@ischoegl ischoegl deleted the remove-obsolete-blessed branch September 3, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants