-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes for IonFlame issues #912
Conversation
@BangShiuh ... could you have a brief look at this (and the corresponding bug report in #911)? |
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 71.19% 71.21% +0.02%
==========================================
Files 376 376
Lines 46211 46199 -12
==========================================
+ Hits 32898 32900 +2
+ Misses 13313 13299 -14
Continue to review full report at Codecov.
|
|
b73bb8d
to
14ba5f2
Compare
@bryanwweber ... I added plots to the examples, and fixed another glitch for the |
3793288
to
279e0d1
Compare
The change corrects an apparent glitch in the code, making sure that the C++ IonFlow::m_do_electric_field booleans are set correctly. As the C++ flags remain unused, the change has no effect on the Poisson solver.
279e0d1
to
309429d
Compare
After cherry-picking 3 fixes into #905, the remaining changes are not worth keeping this PR open. |
Changes proposed in this pull request
Apply band-aid fix tocherry-picked to Fix examples #905ion_burner_flame.py
- a reduction of domain size makes the example more stable; there is no apparent reason for simulations to fail on a larger domain, which points at underlying issues that should be fixed at a later pointFixcherry-picked to Fix examples #905ch4_ion.yaml
that did not matchch4_ion.cti
IonFlow
-based examplesFix export ofcherry-picked to Fix examples #905_other
columns fromIonFlow
(i.e. grid, etc.)Additional issues that surfaced while reviewing code are listed in #913 - changes are more extensive and should be handled by a separate PR (potentially after the release of 2.5).
PS: After cherry-picking 3 fixes into #905, the remaining changes are not worth keeping this PR open.
If applicable, fill in the issue number this pull request is fixing
Fixes #909
Checklist
scons build
&scons test
) and unit tests address code coverage