Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppVeyor Breakage #879

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix AppVeyor Breakage #879

merged 1 commit into from
Jun 24, 2020

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jun 21, 2020

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

If applicable, fill in the issue number this pull request is fixing

Fixes #878

Changes proposed in this pull request

  • Fix deprecation in np.array, where dtype no longer supports np.integer.
  • Use np.uint64 instead (i.e. in analogy to C++ size_t)

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   71.56%   71.56%           
=======================================
  Files         372      372           
  Lines       44510    44510           
=======================================
  Hits        31853    31853           
  Misses      12657    12657           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15b447...0f2fd88. Read the comment docs.

@bryanwweber bryanwweber merged commit 64924d2 into Cantera:master Jun 24, 2020
@bryanwweber
Copy link
Member

Thanks for the quick fix!

@ischoegl ischoegl deleted the fix-appveyor branch July 13, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppVeyor CI apparently broken
2 participants