Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass arguments to equilibrate from fortran to cpp #870

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

dholland88
Copy link

@dholland88 dholland88 commented Jun 19, 2020

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

If applicable, fill in the issue number this pull request is fixing

Fixes #

-Sorry, I broke this... As per the title, the c++ end was receiving rubbish from fortran.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #870 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files         372      372           
  Lines       44503    44503           
=======================================
  Hits        31851    31851           
  Misses      12652    12652           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a591b4...26f4f3c. Read the comment docs.

@speth speth merged commit 4bf3baa into Cantera:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants