[Thermo] Provide const access for speciesThermo() #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 71.40% 71.56% +0.16%
==========================================
Files 372 372
Lines 43605 44501 +896
==========================================
+ Hits 31134 31849 +715
- Misses 12471 12652 +181
Continue to review full report at Codecov.
|
|
You may want to move this change off your master branch as well, considering what happened to #811 😄 |
ischoegl
reviewed
Jun 3, 2020
AUTHORS
Outdated
| @@ -18,7 +18,7 @@ Steven DeCaluwe (@decaluwe), Colorado School of Mines | |||
| Vishesh Devgan (@vdevgan) | |||
| Thomas Fiala (@thomasfiala), Technische Universität München | |||
| David Fronczek | |||
| @g3bk47 | |||
| Thorsten Zirwes, Karlsruhe Institute of Technology | |||
There was a problem hiding this comment.
Quick comment: authors are sorted by last name. Also, you may want to retain your GitHub handle.
|
Thanks for the hint. I created a new commit to fix the order of authors |
speth
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide const access for speciesThermo() member function in case the in case the actual thermo object is only available as const reference and the user wants information about the species thermo.