Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MATLAB] Deprecate IdealGasMix function #806

Merged
merged 2 commits into from
Feb 22, 2020

Conversation

bryanwweber
Copy link
Member

The Solution function provides the same utility for creating Solutions.
Conversion to YAML format files should be done using the command line
tool.

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

The Solution function provides the same utility for creating Solutions.
Conversion to YAML format files should be done using the command line
tool.
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on deprecating this function.

I think the docstring needs to be updated to indicate the deprecation as well.

@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #806 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
- Coverage   71.54%   71.39%   -0.16%     
==========================================
  Files         372      372              
  Lines       44348    43482     -866     
==========================================
- Hits        31730    31045     -685     
+ Misses      12618    12437     -181
Impacted Files Coverage Δ
include/cantera/thermo/PDSS.h 0% <0%> (-100%) ⬇️
include/cantera/equil/vcs_MultiPhaseEquil.h 0% <0%> (-100%) ⬇️
include/cantera/equil/MultiPhaseEquil.h 0% <0%> (-95%) ⬇️
include/cantera/thermo/MolalityVPSSTP.h 20% <0%> (-80%) ⬇️
include/cantera/transport/GasTransport.h 20% <0%> (-80%) ⬇️
include/cantera/thermo/SpeciesThermoInterpType.h 20% <0%> (-70%) ⬇️
include/cantera/base/global.h 38.46% <0%> (-54.88%) ⬇️
include/cantera/thermo/VPStandardStateTP.h 20% <0%> (-51.43%) ⬇️
include/cantera/thermo/Phase.h 50% <0%> (-36.05%) ⬇️
src/clib/Cabinet.h 0% <0%> (-26.42%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53eca8e...e81faa0. Read the comment docs.

@speth speth merged commit 68a0226 into Cantera:master Feb 22, 2020
@bryanwweber bryanwweber deleted the deprecate-idealgasmix branch January 30, 2021 02:26
@bryanwweber bryanwweber restored the deprecate-idealgasmix branch January 30, 2021 02:26
@bryanwweber bryanwweber deleted the deprecate-idealgasmix branch January 30, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants