Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Include non-numeric text in test_problems comparisons #785

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

speth
Copy link
Member

@speth speth commented Jan 3, 2020

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage

Changes proposed in this pull request
The comparison code for the output of "test_problems" tests had an error in its logic where lines where all of the numerical values were nearly identical would get counted as equal, even if other text on those lines was not the same. This even applied to lines with no numerical values.

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #785 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   71.41%   71.45%   +0.03%     
==========================================
  Files         372      372              
  Lines       43904    43962      +58     
==========================================
+ Hits        31355    31414      +59     
+ Misses      12549    12548       -1
Impacted Files Coverage Δ
test/kinetics/kineticsFromYaml.cpp 97.64% <0%> (-2.36%) ⬇️
src/thermo/HMWSoln.cpp 71.58% <0%> (+0.04%) ⬆️
src/kinetics/KineticsFactory.cpp 95.32% <0%> (+0.8%) ⬆️
src/base/AnyMap.cpp 87.44% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237936c...7dddce0. Read the comment docs.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@speth speth merged commit 6925743 into Cantera:master Jan 10, 2020
@speth speth deleted the fix-test-text branch November 20, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants