Fix some issues with Fortran samples #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfortran 7.4 complains about "rank mismatch" in implicit ickwrk and rckwrk variables.
This eliminates the need to set LD_LIBRARY_PATH when using libraries that are not on the standard search path.
speth
force-pushed
the
fix-fortran-samples
branch
from
1e59dbd
to
fd353cd
Compare
bryanwweber
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scons build&scons testscons samples) and unit tests address code coverageI ran into some issues while using the conda-packaged MKL to provide BLAS/LAPACK support that affected the ability to build the samples using the
scons samplescommand.Also, we now use
rpathin the generatedSConstructfiles for the samples, so that it isn't necessary to specifyLD_LIBRARY_PATHwhen running the compiled binaries.