Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surface reactions with explicit reverse rate #754

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Nov 18, 2019

Please fill in the issue number this pull request is fixing

Fixes #634

Changes proposed in this pull request

  • fix type of reaction for surface reactions with explicit reverse rate

@rwest
Copy link
Member

rwest commented Nov 18, 2019

Looks good to me (just glancing at the diff). Thanks for fixing.

@ischoegl
Copy link
Member Author

You're welcome!

@speth speth merged commit 088c52f into Cantera:master Nov 18, 2019
@ischoegl ischoegl deleted the fix-explicit-reverse-surface-rxn branch December 16, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting surface reactions with explicit reverse ratesdoes not generat a pair of surface_reactions
3 participants