-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate magic numbers for RxnRates.h and Falloff.h #733
Conversation
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 70.86% 70.82% -0.04%
==========================================
Files 374 374
Lines 43683 43703 +20
==========================================
Hits 30954 30954
- Misses 12729 12749 +20
Continue to review full report at Codecov.
|
36e6b43
to
715caae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always glad to see magic numbers go away, and this looks pretty good to me. I had just a couple of minor comments / questions.
715caae
to
a28272b
Compare
a28272b
to
0ca7889
Compare
I switched the type string to |
Changes proposed in this pull request:
int type()
methods inRxnRates.h
.int getType()
and introducestring type()
inFalloff.h
I am leaving the remaining magic numbers for kinetics objects as they are, as it may make sense to convert handling of various types to factories instead of having things hard-coded (this is more elaborate and should be handled by a separate PR).